Datahub: support thesaurus based advanced fields #719
Conversation
as we search on a key term, not on a simple term
fields is in the domain and should not depend on gn4 repository implementation. this should pass through the platform interface abstraction
to fetch all keywords in the requested language. Implementation done for gn4, note that it uses a search request, with a limit of 1000, will be an issue in the long run
|
Affected libs:
|
as /sourceS/harvester is not compatible in 4.2.2
| @@ -4,7 +4,7 @@ | |||
| class="py-[37px] pl-[47px] rounded-lg border bg-white mb-5 card-shadow cursor-pointer" | |||
| [figure]="recordsCount$ | async" | |||
| [icon]="'folder_open'" | |||
| [title]="'catalog.figures.datasets'" | |||
| title="catalog.figures.datasets" | |||
There was a problem hiding this comment.
why not use the translate pipe here, instead of marker? I know it's translated too in the gn-ui-figure component but amaybe that's the thing that doesn't make sense (translating inputs in presentation components mean the translation keys will not be discoverable)
There was a problem hiding this comment.
Ok I just saw the approval from Angie.
I've merged it.
I also found it weird that the translation is done in the children, I understood that it's because in the children component, the translations use params.
<div translate class="title truncate" [translateParams]="{ count: figure }">
{{ title }}
</div>But yes, translations should be done from the parent IMO.
| translateKey(key: string): Observable<string> { | ||
| return this.keyTranslations$.pipe(map((translations) => translations[key])) | ||
| } |
Depends on #718
Gn4ToolApi(for translation package)The contact field will be handled in another PR, as I figured out that it is the same as the
OrganizationFieldwith the metadata strategy.